-
-
Notifications
You must be signed in to change notification settings - Fork 21.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCons: Replace _find_scu_section_name
function with SCons builtins
#98888
Conversation
Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
fc3042a
to
32e2b45
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More native SCons implementations are always a plus!
_find_scu_section_name
function with SCons builtins
I've just found that |
Usually just because the author of the builder was more familiar with Python than the SCons API. Cleaning things up by making use of SCons features is usually a good change. |
Oh. I was a bit wrong. It returns in format |
Thanks! |
Followup to godotengine#98888. Note here can't be any regressions like godotengine#99607 because here separator is not OS dependent and set explicitly Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com>
Not only that it is a clean up and ammending of custom workaround but it also transparently allows to process SCons specific paths which contains
#
in the starts (which in turn in the future should allow me to implement SCU for thirdparty sources which should greatly increase compilation speed)