Add thirdparty/ ubsan suppressions for TPS demo #100382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Dec 13, 2024
| implicit-integer-sign-change:thirdparty/zlib/trees.c | ||
| implicit-integer-sign-change:thirdparty/zstd/compress/zstd_cwksp.h | ||
| integer-divide-by-zero:thirdparty/misc/ok_color.h |
There was a problem hiding this comment.
Did you mean to remove this one?
There was a problem hiding this comment.
Yeah, it supposed to be float, not int. It is added back in as well.
There was a problem hiding this comment.
Actually there's another case of this. I'll need to do another force push. It seems that github ci sometimes decides to not give me the latest logs...
There was a problem hiding this comment.
Okay, this is definitely good now. I checked the github ci, and ran the same test locally, and the output matches.
With these suppressions it is possible to import and run the TPS demo without any thirdparty/ reported ubsan. This is useful because it is a complex project, so it is good for testing if new errors show up in our own code.
hpvb
force-pushed
the
thirdparty-ubsan-tpsdemo
branch
from
af3c809 to
49a19db
Compare
|
I think this can be merged, there's no more |
akien-mga
approved these changes
Dec 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these suppressions it is possible to import and run the TPS demo without any thirdparty/ reported ubsan.
This is useful because it is a complex project, so it is good for testing if new errors show up in our own code.
Sorry for the double PR, I could've rolled this into the previous one, but I didn't think to do this until now. This should be the last of it though.