Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thirdparty/ ubsan suppressions for TPS demo #100382

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Add thirdparty/ ubsan suppressions for TPS demo #100382

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions misc/error_suppressions/ubsan.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,36 @@
enum:thirdparty/glslang/SPIRV/spirv.hpp
float-divide-by-zero:thirdparty/amd-fsr2/ffx_fsr2.cpp
float-divide-by-zero:thirdparty/misc/ok_color.h
float-divide-by-zero:thirdparty/rvo2/rvo2_2d/Agent2d.cpp
float-divide-by-zero:thirdparty/thorvg/src/renderer/sw_engine/tvgSwFill.cpp
function:thirdparty/embree/common/sys/thread.cpp
function:thirdparty/embree/kernels/common/accel.h
function:thirdparty/xatlas/xatlas.cpp
implicit-integer-sign-change:thirdparty/basis_universal/transcoder/basisu_astc_helpers.h
implicit-integer-sign-change:thirdparty/embree/common/lexers/../sys/ref.h
implicit-integer-sign-change:thirdparty/embree/common/lexers/tokenstream.cpp
implicit-integer-sign-change:thirdparty/embree/common/sys/sysinfo.cpp
implicit-integer-sign-change:thirdparty/embree/common/tasking/taskschedulerinternal.cpp
implicit-integer-sign-change:thirdparty/embree/common/tasking/taskschedulerinternal.h
implicit-integer-sign-change:thirdparty/embree/kernels/bvh/../common/../builders/primref.h
implicit-integer-sign-change:thirdparty/embree/kernels/bvh/../common/../../common/sys/../math/../simd/vfloat4_sse2.h
implicit-integer-sign-change:thirdparty/embree/kernels/bvh/../common/../../common/sys/../math/../simd/vuint4_sse2.h
implicit-integer-sign-change:thirdparty/embree/kernels/bvh/../common/vector.h
implicit-integer-sign-change:thirdparty/embree/kernels/bvh/../geometry/triangle.h
implicit-integer-sign-change:thirdparty/glslang/glslang/MachineIndependent/ParseHelper.cpp
implicit-integer-sign-change:thirdparty/glslang/glslang/MachineIndependent/preprocessor/PpScanner.cpp
implicit-integer-sign-change:thirdparty/glslang/glslang/MachineIndependent/preprocessor/PpTokens.cpp
implicit-integer-sign-change:thirdparty/glslang/glslang/MachineIndependent/Versions.cpp
implicit-integer-sign-change:thirdparty/glslang/SPIRV/hex_float.h
implicit-integer-sign-change:thirdparty/harfbuzz/src/hb-algs.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/hb-buffer.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/hb-cache.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/hb-face.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/hb-ot-layout-gsubgpos.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/OT/Layout/GDEF/../../../hb-cache.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/OT/Layout/GPOS/../../../hb-ot-layout-gsubgpos.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/OT/Layout/GPOS/../../../OT/Layout/GDEF/../../../hb-cache.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/OT/Layout/GSUB/../../../hb-ot-layout-gsubgpos.hh
implicit-integer-sign-change:thirdparty/harfbuzz/src/OT/name/name.hh
implicit-integer-sign-change:thirdparty/icu4c/common/bmpset.cpp
implicit-integer-sign-change:thirdparty/icu4c/common/ubidiln.cpp
Expand All @@ -19,14 +46,18 @@ implicit-integer-sign-change:thirdparty/mbedtls/library/base64.c
implicit-integer-sign-change:thirdparty/misc/smolv.cpp
implicit-integer-sign-change:thirdparty/recastnavigation/Recast/Include/Recast.h
implicit-integer-sign-change:thirdparty/recastnavigation/Recast/Source/RecastMesh.cpp
implicit-integer-sign-change:thirdparty/spirv-reflect/spirv_reflect.c
implicit-integer-sign-change:thirdparty/thorvg/src/renderer/sw_engine/tvgSwRaster.cpp
implicit-integer-sign-change:thirdparty/tinyexr/tinyexr.h
implicit-integer-sign-change:thirdparty/vulkan/vk_mem_alloc.h
implicit-integer-sign-change:thirdparty/xatlas/xatlas.cpp
implicit-integer-sign-change:thirdparty/zlib/trees.c
implicit-integer-sign-change:thirdparty/zstd/compress/zstd_cwksp.h
integer-divide-by-zero:thirdparty/misc/ok_color.h
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to remove this one?

Copy link
Member Author

@hpvb hpvb Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it supposed to be float, not int. It is added back in as well.

see here: https://github.com/godotengine/godot/pull/100382/files#diff-5b994f1a4a419f95b944677136abfe3ea0777a6830f5240ea4d9f3434f7d9713R3

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually there's another case of this. I'll need to do another force push. It seems that github ci sometimes decides to not give me the latest logs...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is definitely good now. I checked the github ci, and ran the same test locally, and the output matches.

integer-divide-by-zero:thirdparty/rvo2/rvo2_2d/Agent2d.cpp
nonnull-attribute:thirdparty/spirv-reflect/spirv_reflect.c
pointer-overflow:thirdparty/libogg/framing.c
shift-base:thirdparty/libogg/bitwise.c
shift-base:thirdparty/libvorbis/sharedbook.c
shift-base:thirdparty/noise/FastNoiseLite.h
shift-base:thirdparty/tinyexr/tinyexr.h
shift-exponent:thirdparty/misc/mikktspace.c
signed-integer-overflow:thirdparty/noise/FastNoiseLite.h
Loading