Fix: RayCast3D.get_collider does not return a CollisionShape3D

[Akshajk3]

• Modified the RayCast3D.get_collider() function to ensure it only returns CollisionObject3D instances.
• The function now uses Object::cast_to<CollisionObject3D>(object) to perform a safe cast and return null if the object is not of the expected type.
• This resolves issues where RayCast3D.get_collider() could return objects like CSGShape3D, leading to runtime errors and incorrect behavior.

Fixes: #100139

[Sauermann]

This is likely not the right way to fix the issue. The documentation should be updated.
Please be aware of the comment here: #100139 (comment)

[Akshajk3]

Hi, sorry for the mistake. It is my first time contributing, and I was unsure of exactly what the tags meant. To clarify, does the "documentation" tag mean it is an issue with the docs that need to be updated, not the code?

[Sauermann]

Thank you for your effort. No worries!
That is right: the code should not change, but rather the documentation needs to be updated to correctly describe the actual behavior.

[Akshajk3]

Just a quick question, I was wondering if there was documentation for the source code itself, because I get a bit confused when looking through the codebase for the right files.

[Sauermann]

You might find this a good place to start.

godot/doc/classes/RayCast3D.xml

Line 7 in dc5f1b7

A raycast represents a ray from its origin to its [member target_position] that finds the closest [CollisionObject3D] along its path, if it intersects any.

[AThousandShips]

Thank you for your contribution! Closing in favour of:

• Clarify expected types in RayCast3D documentation  #101373

Which is the appropriate solution, thank you nonetheless!