Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify expected types in RayCast3D documentation #101373

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Clarify expected types in RayCast3D documentation #101373

merged 1 commit into from
Jan 11, 2025

Conversation

jburt137
Copy link
Contributor

@jburt137 jburt137 commented Jan 9, 2025 •
edited by AThousandShips
Loading

Updating documentation, per #100139 (comment)

rburing
on Dec 7, 2024
Member
Yes, the documentation is wrong (too narrow). In addition to CSG there's also GridMap. Fixes to the documentation are welcome.

@jburt137 jburt137 requested a review from a team as a code owner January 9, 2025 22:23
@jburt137 jburt137 mentioned this pull request Jan 10, 2025
Closed
@AThousandShips AThousandShips changed the title Update RayCast3D.xml per Issue #100139 Clarify expected types in RayCast3D documentation Jan 10, 2025
@AThousandShips AThousandShips added bug documentation cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 10, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 10, 2025
AThousandShips
AThousandShips reviewed Jan 10, 2025
View reviewed changes
@AThousandShips AThousandShips mentioned this pull request Jan 10, 2025
Closed
jburt137
jburt137 commented Jan 10, 2025
View reviewed changes
Copy link
Contributor Author

@jburt137 jburt137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made all the recommended changes. Please review.

@AThousandShips
Copy link
Member

Will review when you've added all the suggestions

AThousandShips
AThousandShips approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jburt137
jburt137 commented Jan 10, 2025
View reviewed changes
Copy link
Contributor Author

@jburt137 jburt137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to me like I have accepted all the suggestions, did I miss any? Please let me know. Thank you.

@akien-mga
Copy link
Member

Looks good! Could you squash the commits? See PR workflow for instructions.

If that process seems daunting, feel free to let us know and a maintainer can also squash the commits for you.

@akien-mga
Copy link
Member

Seems like something went wrong with the previous attempt at squashing commits, so I went ahead and cleaned it up myself. This should be good to merge now.

@akien-mga akien-mga merged commit 956e2b1 into godotengine:master Jan 11, 2025
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

@jburt137
Copy link
Contributor Author

Thanks all for your help! I plan to help out with more issues, of increasing difficulty.

@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release documentation
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

RayCast3D.get_collider does not return a CollisionShape3D
3 participants
@jburt137 @AThousandShips @akien-mga