Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NavLinkIteration bidirectional #100771

Closed
wants to merge 1 commit into from
Closed

Fix NavLinkIteration bidirectional #100771

wants to merge 1 commit into from

Conversation

smix8
Copy link
Contributor

@smix8 smix8 commented Dec 23, 2024 •
edited
Loading

Fixes missing NavLinkIteration bidirectional property that got lost in some file shuffling.

Fixes #100769

@smix8 smix8 added this to the 4.4 milestone Dec 23, 2024
@smix8 smix8 requested a review from a team as a code owner December 23, 2024 17:43
Geometror
Geometror approved these changes Dec 23, 2024
View reviewed changes
Copy link
Member

@Geometror Geometror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick test with the MRP, works! Those 4 changed lines look fine too :)

@smix8
Fix NavLinkIteration bidirectional
55acbe9 
Fixes missing NavLinkIteration bidirectional property.
@smix8
Copy link
Contributor Author

smix8 commented Dec 26, 2024 •
edited
Loading

Closing as this is included in #100823 that takes priority so we dont get another batch of bugs from rebasing.

@smix8 smix8 closed this Dec 26, 2024
@smix8 smix8 added the archived label Dec 26, 2024
@smix8 smix8 deleted the navlink_bi branch December 26, 2024 11:33
@AThousandShips AThousandShips removed this from the 4.4 milestone Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiroxas kiroxas kiroxas approved these changes

@Geometror Geometror Geometror approved these changes

Assignees
No one assigned
Labels
archived bug regression topic:navigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bidirectional flag in NavigationLink3D is no longer taken into account by NavigationAgent3D
4 participants
@smix8 @kiroxas @Geometror @AThousandShips