Prevent tooltip from showing when hovering past the end of script line

[larspet]

Fixes #100767

TextEdit::get_line_column_at_pos() already had an option to not allow "out of bounds" access, but it only checked if the row was OOB, not the column. This PR renames that argument and adds an extra argument that allows for checking the column as well.

Before

tooltip_before.mp4

After

tooltip_after.mp4

[Mickeon]

I wonder, why would one ever want the existing behaviour enough to warrant it being an optional argument?

[larspet]

I wonder, why would one ever want the existing behavior enough to warrant it being an optional argument?

For get_line_column_at_pos() I can see why it's needed, e.g. in order to put the caret at the last column when clicking past the end of the line. Although I think the argument is backwards, and should be named p_clamp_position or something instead.

The reason I added the argument to get_word_at_pos() was to give them similar API, and not potentially break current uses of it. That said, looking at the other few existing uses of it in the engine, this new functionality would be wanted there too. I can't speak for any user code already utilizing the function however.

If wanted, I would not be against not adding this new argument, and instead changing the current behavior of get_word_at_pos() instead.

[dalexeev]

I'm not a node GUI expert, but the code looks good to me, I tested it and it works fine.

[kitbdev]

The behavior of get_line_column_at_pos when allow oob is false shouldn't change. A new parameter can be added to it for horizontal checking, and the existing one's name can be changed.
This is because there is code that relies on the current behavior of only checking vertical like in CodeEdit::get_cursor_shape for the fold icon, and users may be relying on it too. I would also like to use it for gutters, see #101613.

[larspet]

I removed the optional argument from get_word_at_pos since there really wasn't any point to it. The new behavior follows the expected behavior much more anyways.

Instead, I split the argument in get_line_column_at_pos into two (line & column). This way the old behavior is kept (so that e.g. the line-folding ... icon works), while also optionally allowing to disallow clamping for the column.

[Calinou]

Tested locally, it works as expected. Code and docs look good to me.

[akien-mga]

Thanks!