Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TextEdit breakpoint hover not hiding on mouse exit #101613

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented Jan 15, 2025

The area below the last line is no longer part of the last line's gutter.
The hovering, mouse cursor shape, and clicking gutter now uses the same logic.
Updating the gutter (add/remove/change size) now immediately updates the hover as well.
Added some gutter hover and click tests.

@kitbdev kitbdev requested review from a team as code owners January 15, 2025 23:02
@kitbdev kitbdev force-pushed the fix-te-hover-mouse-exit branch from b0d8105 to 2d587e4 Compare January 15, 2025 23:11
@AThousandShips AThousandShips added bug topic:gui usability cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 16, 2025
@AThousandShips AThousandShips added this to the 4.4 milestone Jan 16, 2025
Copy link
Contributor

@MewPurPur MewPurPur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code and tested the changes, it all looks good.

I see breakpoints left behind all the time now when using the code editor, so I think it would be a good idea to merge this during beta to clear up this jank for 4.4

@kitbdev kitbdev force-pushed the fix-te-hover-mouse-exit branch from 2d587e4 to 8274e64 Compare January 16, 2025 15:43
@kitbdev
Copy link
Contributor Author

kitbdev commented Jan 16, 2025

Removed the CodeEdit mouse exit redraw, I don't think anything else was relying on it and I didn't notice any issues.

I don't think this can be cherry-picked. The breakpoint indicator did hide during 4.1 to 4.3 from #78509, it was just recently re-introduced in #65517.
This PR also relies on the changes #65517 made for the breakpoint hover, so without it this also may not fix the click logic and hover logic being different.

@syntaxerror247 syntaxerror247 removed cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 18, 2025
@syntaxerror247
Copy link
Member

Removed cherrypick labels due to the reason mentioned by @kitbdev in above comment.

Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. I made sure this doesn't cause unnecessary redraws.

Code looks good to me.

@Repiteo Repiteo merged commit c032ce4 into godotengine:master Jan 22, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 22, 2025

Thanks!

@kitbdev kitbdev deleted the fix-te-hover-mouse-exit branch January 23, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The breakpoint hover indicator doesn't overlap with its click detection
6 participants