-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TextEdit breakpoint hover not hiding on mouse exit #101613
Conversation
b0d8105
to
2d587e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the code and tested the changes, it all looks good.
I see breakpoints left behind all the time now when using the code editor, so I think it would be a good idea to merge this during beta to clear up this jank for 4.4
2d587e4
to
8274e64
Compare
Removed the CodeEdit mouse exit redraw, I don't think anything else was relying on it and I didn't notice any issues. I don't think this can be cherry-picked. The breakpoint indicator did hide during 4.1 to 4.3 from #78509, it was just recently re-introduced in #65517. |
Removed cherrypick labels due to the reason mentioned by @kitbdev in above comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, it works as expected. I made sure this doesn't cause unnecessary redraws.
Code looks good to me.
Thanks! |
The area below the last line is no longer part of the last line's gutter.
The hovering, mouse cursor shape, and clicking gutter now uses the same logic.
Updating the gutter (add/remove/change size) now immediately updates the hover as well.
Added some gutter hover and click tests.