Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document WorldBoundaryShape3D having a finite size when using Jolt Physics #101108

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 3, 2025

This also mentions Jolt Physics in the ProjectSettings 3D physics engine documentation.

Not cherry-pickable to 4.3, as Jolt Physics isn't present there.

@Calinou Calinou requested a review from a team as a code owner January 3, 2025 23:15
@Calinou Calinou added this to the 4.4 milestone Jan 3, 2025
@Calinou Calinou force-pushed the doc-worldboundaryshape3d-finite-size branch 2 times, most recently from 2c9ea21 to 83578c4 Compare January 4, 2025 01:44
@Calinou Calinou force-pushed the doc-worldboundaryshape3d-finite-size branch from 83578c4 to 31ccbe0 Compare January 11, 2025 17:28
…ysics

This also mentions Jolt Physics in the ProjectSettings 3D physics engine
documentation.
@Calinou Calinou force-pushed the doc-worldboundaryshape3d-finite-size branch from 31ccbe0 to e668188 Compare January 14, 2025 21:21
@Repiteo Repiteo merged commit 679075b into godotengine:master Jan 16, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 16, 2025

Thanks!

@@ -5,6 +5,7 @@
</brief_description>
<description>
A 3D world boundary shape, intended for use in physics. [WorldBoundaryShape3D] works like an infinite plane that forces all physics bodies to stay above it. The [member plane]'s normal determines which direction is considered as "above" and in the editor, the line over the plane represents this direction. It can for example be used for endless flat floors.
[b]Note:[/b] When the physics engine is set to [b]Jolt Physics[/b] in the project settings ([member ProjectSettings.physics/3d/physics_engine]), [WorldBoundaryShape3D] has a finite size (centered at the world origin). It can be adjusted by changing [member ProjectSettings.physics/jolt_physics_3d/limits/world_boundary_shape_size].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm the only one confused by this, but is "the world origin" meant to refer to global (0, 0, 0) or the origin of the shape in the world?

The size is centered around the shape's own origin, and not global (0, 0, 0).

Copy link
Contributor

@Mickeon Mickeon Jan 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable spot to be confused by. I also thought this referred to the origin of the world, instead of the global origin (global position).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Calinou Calinou deleted the doc-worldboundaryshape3d-finite-size branch January 20, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants