Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix inverted GPUParticlesCollisionHeightField3D in compatibility renderer. #101159

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Fix inverted GPUParticlesCollisionHeightField3D in compatibility renderer. #101159

merged 1 commit into from
Jan 20, 2025

Conversation

brandon515
Copy link
Contributor

Followed the thread from issue 100872 and implemented the fix for the particle system for the compatibility shader.

@brandon515 brandon515 requested a review from a team as a code owner January 5, 2025 21:10
@clayjohn clayjohn added bug topic:rendering cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 5, 2025
@clayjohn clayjohn added this to the 4.4 milestone Jan 5, 2025
@AThousandShips AThousandShips changed the title Implemented fix from #91219 in compatibility renderer. Fix inverted GPUParticlesCollisionHeightField3D in compatibility renderer. Jan 6, 2025
Calinou
Calinou approved these changes Jan 18, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

Please reword the commit message to be more informative (using git commit --amend):

Fix inverted GPUParticlesCollisionHeightField3D in the Compatibility rendering method

@Calinou Calinou mentioned this pull request Jan 18, 2025
Closed
@brandon515 brandon515 force-pushed the compatibility_particle_shader_fix branch 2 times, most recently from 05641f3 to c265c19 Compare January 18, 2025 18:31
@brandon515
Implemented fix from godotengine#91219 in compatibility renderer by r…
9906120 
…eversing the z

axis in the particle shader.
@brandon515 brandon515 force-pushed the compatibility_particle_shader_fix branch from c265c19 to 9906120 Compare January 18, 2025 18:32
@brandon515
Copy link
Contributor Author

Updated the commit message to state that the fix was to reverse the z axis in the particle shader.

@Repiteo Repiteo merged commit dcf4996 into godotengine:master Jan 20, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Jan 20, 2025

Thanks! Congratulations on your first merged contribution! 🎉

@Spartan322 Spartan322 mentioned this pull request Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:particles topic:rendering topic:3d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@brandon515 @Repiteo @Calinou @clayjohn