Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inverted GPUParticlesCollisionHeightField3D in the Compatibility rendering method #101751

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 18, 2025

This ports the same fix already used in Forward+/Mobile to account for reverse Z.

Preview

Using the MRP from #100872. Particles are flowing upwards in the demo (as the camera is reversed), hence the particles colliding with the "ceiling" of the cube.

Before  After
Screenshot_20250118_125322 Screenshot_20250118_125618

…rendering method

This ports the same fix already used in Forward+/Mobile to account
for reverse Z.
@Calinou Calinou added bug topic:3d topic:particles cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release labels Jan 18, 2025
@Calinou Calinou added this to the 4.4 milestone Jan 18, 2025
@Calinou Calinou requested a review from a team as a code owner January 18, 2025 12:03
@Calinou
Copy link
Member Author

Calinou commented Jan 18, 2025

I just noticed this already has a PR open: #101159

@Calinou Calinou closed this Jan 18, 2025
@Calinou Calinou removed this from the 4.4 milestone Jan 18, 2025
@AThousandShips AThousandShips removed the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inverted GPUParticlesCollisionHeightField3D on compatibility renderer only
2 participants