Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Add OKHSL properties to Color #101337

Merged
merged 1 commit into from
Jan 11, 2025
Merged

C#: Add OKHSL properties to Color #101337

merged 1 commit into from
Jan 11, 2025

Conversation

beicause
Copy link
Contributor

@beicause beicause commented Jan 9, 2025

Adds OKHSL properties to C# Color, which were exposed to gdscript by #82845 but still missing in C#.

@beicause beicause requested a review from a team as a code owner January 9, 2025 11:30
@AThousandShips AThousandShips added this to the 4.x milestone Jan 9, 2025
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Jan 9, 2025
akien-mga
akien-mga approved these changes Jan 11, 2025
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me for feature parity.

@akien-mga akien-mga merged commit fdd3c8a into godotengine:master Jan 11, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@beicause beicause deleted the csharp-okhsl-properties branch January 12, 2025 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga

Assignees
No one assigned
Labels
enhancement topic:core topic:dotnet
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@beicause @akien-mga @AThousandShips