Color: Expose OKHSL properties

[Hysterelius]

I’m proposing a solution to enhance the Color class by adding an OkHSL lightness attribute. This attribute will facilitate the creation of colour palettes based on predefined colour stops. Currently, this PR exposes a previously private function to public gdscript. I’m unsure how to extend this functionality to C#, and would appreciate any help on this matter.

This PR is an implementation of my feature proposal, just aiming to expose pre-existing infrastructure to the user.

I’ve tested these changes locally and everything appears to be working correctly, but I welcome any feedback or suggestions on my PR’s implementation.

Production edit: Closes godotengine/godot-proposals#7954

[AThousandShips]

You haven't exposed the ok_hsl_h/s values, they are not the same as the h/s values

See also:

• Add color_utils module #76976

[fire]

Ok with the proposal but the cicd has to pass and colours are 32 bit floats.

[AThousandShips]

What use would it be to only have the l value and not the h or s values?

[Hysterelius]

I have now added all the values for ok_hsl (s and h) and rebuilt Godot to fix the docs.

[Hysterelius]

Can this sneak into the 4.2 release @lostminds?

[lostminds]

Can this sneak into the 4.2 release @lostminds?

@Hysterelius I have no say or insight regarding that, I'm just a member of the community. Merging of pull requests and which branch they will go into is decided on by the various Godot core contributor teams. You can see below that this particular one will need review and approval by the core and documentation teams.

[Hysterelius]

Sorry, I just assumed you would have to finish your review before the other teams could look at it.

[AThousandShips]

4.2 is in feature freeze so will likely have to wait for 4.3, this PR was opened just around the time of feature freeze

[nonchip]

@AThousandShips is this really a feature though? feels more like a fix for forgetting to expose the already existing feature in a non-writeonly manner...

[AThousandShips]

That falls under features, it's not a bug but missing functionality, in either case we are close to release so it can soon be looked into once the 4.3 cycle starts

[AThousandShips]

@Kermalis Please don't bump without contributing significant new information. Use the 👍 reaction button on the first post instead.

[fire]

Looks good to me.

I needed a way to reduce the lightness of an existing red colour.

The theory is I'd from a red colour I'd get the existing okhsl values from this enhancement, then use to half the lightness value. from_ok_hsl(h: float, s: float, l: float, alpha: float = 1.0)

Sorry for the delay!

[AThousandShips]

Please squash your commits into one, see the interactive rebase

[akien-mga]

Amended the commit message to be clearer, and tweaked the spelling of OKHSL (it was "OkHSL" in the docs).
Should be good to merge.

[Repiteo]

Thanks!