Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to cancel rotation from viewport rotation gizmo #101369

Conversation

ryevdokimov
Copy link
Contributor

Works with right click or ui_cancel (escape by default).

2025-01-09.16-59-07.mp4

@ryevdokimov ryevdokimov requested a review from a team as a code owner January 9, 2025 22:05
@ryevdokimov ryevdokimov force-pushed the cancel-viewport-rotation-gizmo branch from dabfe98 to e1510b7 Compare January 9, 2025 22:07
@Calinou Calinou added this to the 4.x milestone Jan 9, 2025
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected. Code looks good to me.

For reference, Blender 4.3.2 has the same behavior with its rotation gizmo.

@ryevdokimov
Copy link
Contributor Author

Fixed a small focus issue I discovered while working on: #101376

@ryevdokimov ryevdokimov force-pushed the cancel-viewport-rotation-gizmo branch from 6efd6be to a8f3c97 Compare January 10, 2025 20:41
@ryevdokimov
Copy link
Contributor Author

Fixing another small issue that I found while working on other gizmo stuff. Made is so that you can't accidentally select an axis on left mouse button release after canceling.

@akien-mga akien-mga merged commit 39f73bb into godotengine:master Jan 10, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@ryevdokimov ryevdokimov deleted the cancel-viewport-rotation-gizmo branch January 10, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants