Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add movement threshold before activating viewport rotation gizmo dragging #101376

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryevdokimov
Copy link
Contributor

@ryevdokimov ryevdokimov commented Jan 10, 2025

Requires and Includes: #101369 (This was merged, and this PR was rebased).

This gets activated too quickly, and sometimes accidentally activates when trying to select an axis. This PR adds a movement threshold before activating.

LMB is being held down at the start of the video:

2025-01-09.20-20-48.mp4

@ryevdokimov ryevdokimov force-pushed the movement-threshold-rotation-gizmo branch from dd91b59 to 472cdb6 Compare January 10, 2025 22:20
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally (rebased on top of master b607110), it works as expected.

Code looks good to me, and usability seems good on my end (I can quickly click axes and they get selected correctly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants