Make dialogs non-cancelable on Android #101689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxerror247
changed the title
|
What is the behavior of the native dialogs on desktop OSes? |
|
At least on macOS, native dialogs are non-cancelable (do not have window close button, and do not close on Esc, or clicks outside). |
|
On Windows, input dialog is also non-cancelable, but button dialog is (and do not stay on top of parent, so it's likely a bug). |
|
@bruvzg There seems to be one more bug with button dialog on Windows, Close button also returns |
|
#101697 ← fix for Windows. |
m4gr3d
approved these changes
Jan 17, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses dialog canceling behavior in the app. Currently, native-dialogs are canceled when the user presses the back button or taps outside the dialog.
This PR is disabling this behavior to prevent unintentional dismissals. However, it's open for discussion whether we should disable canceling by both
touch outsideandback press, only touch outside, or leave the current behavior as is.