[Windows] Make native dialogs non-cancelable and stay on top of parent. #101697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't affect headless dialogues? I am trying to review the pull requests related to the stuck headless mode. |
No, headless mode use |
syntaxerror247
approved these changes
Jan 18, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #101689
dialog_showstay on top of parent and button indices do not overlap standard button codes (to make it non-cancelable, sinceTDCBF_CANCEL_BUTTON == 2and was almost always present).dialog_showanddialog_input_textdo not have a close button in the title bar.Native dialogs on macOS have the same behavior.