Fix NOTIFICATION_WM_CLOSE_REQUEST
in Embedded Floating Window
#101895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fixes the notification NOTIFICATION_WM_CLOSE_REQUEST when closing the floating window.
I changed the way the embedded process is closed. In the previous implementation, I based the code on the stop button in the editor which kills the process. Now, I use a native send message in Windows and Linux the close the game window.
I added to rework the
WindowWrapper
to prevent to closing of the floating window while the game is closing. That's why I added theWindowWrapper::set_override_close_request
method.I did not changed the editor stop button, it's working as before. It kills the process, preventing the notification.
Tested on Windows 11 and Ubuntu 23.10.