Fix BadWindow error when stopping embedded game on Linux #102045
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was introduced in the PR #101895 on Linux when using the
Stop
button when the game is embedded. When using theStop
button the game process is killed and the window id becomes invalid. Even with theXSetErrorHandler(&bad_window_error_handler)
, the error is thrown on the next x11 call. Adding a little check to see if the window is still valid before executing theXSendEvent
fixed the issue.The error was:
CC @YeldhamDev