Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Export] Convert uid:// names to res:// when exporting files. #101954

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Export] Convert uid:// names to res:// when exporting files. #101954

wants to merge 1 commit into from
+31 −4

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jan 23, 2025

Should prevent future issues similar to icon/splash issues fixed by #99353 and #100920

@bruvzg bruvzg added this to the 4.x milestone Jan 23, 2025
@bruvzg bruvzg marked this pull request as ready for review January 23, 2025 20:00
@bruvzg bruvzg requested a review from a team as a code owner January 23, 2025 20:00
AThousandShips
AThousandShips approved these changes Jan 24, 2025
View reviewed changes
@akien-mga akien-mga requested a review from KoBeWi March 19, 2025 09:01
@akien-mga akien-mga modified the milestones: 4.x, 4.5 Mar 19, 2025
@KoBeWi
Copy link
Member

KoBeWi commented Mar 19, 2025

Not sure what this PR is trying to achieve. I exported my project (which is quite big) and not a single was saved with UID path, so the added code never had a chance to run. Does it depend on target platform? If it should prevent the issues fixed by the linked PRs, did you test whether it can supersede them? Note that e.g. #100920 might be not relevant anymore, because FileAccess recognizes UIDs now.

@bruvzg
Copy link
Member Author

bruvzg commented Mar 19, 2025

Not sure what this PR is trying to achieve. I exported my project (which is quite big) and not a single was saved with UID path, so the added code never had a chance to run.

Ensure no uid path get saved in PCK. It's not fixing any existing issues, so it's expected to never trigger. Just adding extra level of safety for plugins, which can add exported file without checking path.

KoBeWi
KoBeWi approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose it's harmless.

The repeated code (simplify_path() + UID check) could be a method in EditorExportPlatform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4gr3d m4gr3d m4gr3d approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

@syntaxerror247 syntaxerror247 syntaxerror247 approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor topic:export
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
6 participants
@bruvzg @KoBeWi @m4gr3d @AThousandShips @syntaxerror247 @akien-mga