Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android boot splash and gradle build issue #99353

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

syntaxerror247
Copy link
Member

@syntaxerror247 syntaxerror247 commented Nov 17, 2024

This pull request is built upon PR #99286 and that needs to be merged first.

I have resolved the Android Gradle build export issue introduced in that PR, as well as fixed the boot splash problem on Android.

Fixes #99221

@syntaxerror247 syntaxerror247 requested review from a team as code owners November 17, 2024 11:58
@syntaxerror247 syntaxerror247 changed the title Expand uid support and fix Android export issues Expand uid support and fix Android boot splash issue Nov 17, 2024
@Chaosus Chaosus added this to the 4.4 milestone Nov 17, 2024
@syntaxerror247 syntaxerror247 force-pushed the some_uid_issues branch 2 times, most recently from c9c0f62 to b209a17 Compare November 17, 2024 16:36
@syntaxerror247 syntaxerror247 changed the title Expand uid support and fix Android boot splash issue Fix Android boot splash and gradle build issue Nov 17, 2024
@akien-mga akien-mga requested a review from KoBeWi November 17, 2024 18:30
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test it, but it's similar to #99286

Copy link
Contributor

@m4gr3d m4gr3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Repiteo Repiteo merged commit 650e96b into godotengine:master Nov 19, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 19, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image loading is broken in editor
6 participants