Disable Metal and Vulkan renderers in simulator builds. Remove simulator support from editor/exporter. #102179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor support from editor/exporter.
akien-mga
reviewed
Jan 30, 2025
Comment on lines
-297
to
+296
| // TODO(sgc): set to iOS 14.0 for Metal | ||
| r_options->push_back(ExportOption(PropertyInfo(Variant::STRING, "application/min_ios_version"), "12.0")); | ||
| r_options->push_back(ExportOption(PropertyInfo(Variant::STRING, "application/min_ios_version"), "14.0")); |
There was a problem hiding this comment.
Do we want to give the option to still compile iOS templates without Metal and thus target down to 12.0? Or do we consider that 14.0 is a fine min version either way?
Technically I guess it's still possible as 14.0 is just a default here so users could change it manually to 12.0 in that (advanced) use case?
There was a problem hiding this comment.
It's only default value, you can switch it to 12.0, and it will work with the same template (or custom template) if renderer is set to OpenGL in project settings. But since default is Metal, there's no reason to keep it at 12.0, it's just an annoyance since you have to switch it to 14.0 for each new project.
There was a problem hiding this comment.
Library itself is still built with 12.0 as min. version. We do not need to bump it as long as Xcode/SDK have support for it.
stuartcarnie
approved these changes
Feb 1, 2025
|
Thanks! |
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Feb 7, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
adamscott
pushed a commit
to adamscott/godot
that referenced
this pull request
Feb 8, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
dugramen
pushed a commit
to dugramen/godot
that referenced
this pull request
Feb 8, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
rddi-8
pushed a commit
to rddi-8/godot-custom-features
that referenced
this pull request
Mar 2, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner alternative to #102178
TODO: