Workaround mingw-gcc LTO ICE by re-adding some dead code... #102506
Merged
+239
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
commented
Feb 7, 2025
Comment on lines
2424
to
2429
| // HACK: We don't want to run the simulator library generation code anymore after GH-102179, but removing it | ||
| // triggers an internal compiler error with latest mingw-gcc... For now we bring it back as a workaround | ||
| // with a condition that should never be true (that project setting doesn't exist). | ||
|
|
||
| // Check and generate missing ARM64 simulator library. | ||
| if (ProjectSettings::get_singleton()->has_setting("ios_generate_simulator_library_if_missing")) { |
There was a problem hiding this comment.
This is the main difference with the previous code before #102179. Instead of checking a preset option (which #102179 removed), I'm checking a non-existing project setting. This should prevent the compiler from optimizing all this code away (it doesn't know that the project setting doesn't exist), but should also prevent it from running when exporting to iOS (unless a user decides to create this magic project setting manually).
This should really be a temporary hack (famous last words).
|
Note for when we revert this to replace it by a better fix: the |
clayjohn
reviewed
Feb 7, 2025
Not my finest work, but without that code removed in godotengine#102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO. We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless.
akien-mga
force-pushed
the
mingw-gcc-lto-one-the-rocks
branch
from
b05b3ca to
e12a424
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not my finest work, but without that code that was removed in #102179, mingw-gcc 14.2.1 on Fedora 41 (but also confirmed with versions on macOS and WSL) crashes when linking with LTO with the following command:
And this error:
We need to dig deeper to understand the bug, report it upstream and work it around in a cleaner way. But for now this unblocks building Windows binaries with LTO, and should be harmless. This could likely be made more minimal by cutting through the code I'm re-adding until it fails linking again, but it's pretty tedious and I need to start a 4.4.beta3 build now :)
I'll write a proper bug report tomorrow so we can keep tracking that issue and make sure to revert this hack and replace it by an actual fix.
More details in this Rocket.chat thread: https://chat.godotengine.org/channel/buildsystem?msg=3LzNsqenWK55Bb8gt