Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Fix node selection within SubViewports using size 2d override #102390

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Editor: Fix node selection within SubViewports using size 2d override #102390

merged 1 commit into from
Feb 5, 2025

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Feb 4, 2025 •
edited
Loading

Fix single and rectangular selection inside SubViewport when the viewport uses a size 2d override.

Closes #102388

Demonstration
before after
CleanShot 2025-02-04 at 12 41 19 CleanShot 2025-02-04 at 12 43 48

@akien-mga akien-mga requested a review from a team February 4, 2025 06:28
@akien-mga akien-mga added this to the 4.4 milestone Feb 4, 2025
@akien-mga akien-mga added the cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release label Feb 4, 2025
@akien-mga akien-mga changed the title editor: Fix node selection within SubViewports using size 2d override Editor: Fix node selection within SubViewports using size 2d override Feb 4, 2025
@kitbdev
Copy link
Contributor

kitbdev commented Feb 4, 2025

Similar logic is also used in _find_canvas_items_in_rect. So it should probably be changed there as well, for box select.

@stuartcarnie
Copy link
Contributor Author

Similar logic is also used in _find_canvas_items_in_rect. So it should probably be changed there as well, for box select.

Good shout – fixed.

@akien-mga akien-mga merged commit ff0049e into godotengine:master Feb 5, 2025
19 checks passed
@akien-mga
Copy link
Member

Thanks!

@stuartcarnie stuartcarnie deleted the 102388/fix_selection branch February 5, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleonc kleonc kleonc approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.3 Considered for cherry-picking into a future 4.3.x release topic:editor topic:2d
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

Unable to select items in SubViewport with size 2D override
4 participants
@stuartcarnie @kitbdev @akien-mga @kleonc