Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Fix issue when pausing an non-started sample #102955

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[Web] Fix issue when pausing an non-started sample #102955

merged 1 commit into from
Feb 18, 2025
+3 −0

Conversation

adamscott
Copy link
Member

This PR makes sure that the sample source is at least started before calling stop() on it.

Fixes #102911.

@adamscott adamscott added this to the 4.4 milestone Feb 17, 2025
@adamscott adamscott requested a review from a team as a code owner February 17, 2025 14:50
Calinou
Calinou approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

akien-mga
akien-mga approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Noting that we're about to release 4.4.beta4, so this will be included in the next build (4.4.rc1 most likely).

@Repiteo Repiteo merged commit e2b2dce into godotengine:master Feb 18, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 18, 2025

Thanks!

@bs
Copy link

bs commented Feb 21, 2025

@adamscott I owe you a coffee. =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:audio
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

[4.4 Beta3] A Web Audio malfunction that causes the entire game to stop.
5 participants
@adamscott @Repiteo @bs @Calinou @akien-mga