Implement debug CanvasItem redraw in GLES3 #103018
Open
+83
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleonc
force-pushed
the
canvas_item_debug_redraw_gles3_implementation
branch
from
e7c4633 to
1938b6f
Compare
kleonc
force-pushed
the
canvas_item_debug_redraw_gles3_implementation
branch
from
1938b6f to
4f8c26e
Compare
kleonc
commented
Feb 19, 2025
| @@ -1294,8 +1364,6 @@ _FORCE_INLINE_ static uint32_t _indices_to_primitives(RS::PrimitiveType p_primit | |||
| } | |||
|
|
|||
| void RasterizerCanvasGLES3::_render_batch(Light *p_lights, uint32_t p_index, RenderingMethod::RenderInfo *r_render_info) { | |||
| ERR_FAIL_NULL(state.canvas_instance_batches[state.current_batch_index].command); | |||
There was a problem hiding this comment.
Removing it to allow .command_type = Item::Command::TYPE_RECT with .command = nullptr used for debug redraw, added null checks for cases where .command is actually dereferenced.
Also seems the check here was faulty anyway, as state.canvas_instance_batches[p_index] should be checked instead of state.canvas_instance_batches[state.current_batch_index].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLES3 version of #79169.
Based also on #98652 which reimplemented it after batching.
Includes fix from #103017.
I'm absolutely not sure if I got all batch state reseting etc. correctly so please check thoroughly. Well, of course it works as far as I've tested. 🙃