Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D: Fix various issues and minor performance optimizations #98652

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Oct 29, 2024

Summary

This PR includes a number of important bug fixes and a performance improvement for managing the texture state and DrawData in uniform set 3.

Another important change in this PR is to move the specular_shininess to PushConstant state, allowing the field to be used for #97058.

Closing #97340 in favour of this, noting that this PR will not address font rendering improvements, which will require separate work. It does improve the performance of text rendering of the test in this comment from 40 fps to 76 fps, due to the minor CPU optimisations included in this PR.

Bugfixes

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great and I am able to reproduce the performance improvement in CPU-bound scenarios.

@Repiteo Repiteo merged commit a8931f1 into godotengine:master Oct 30, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 30, 2024

Thanks!

@stuartcarnie stuartcarnie deleted the 2d_texture_state_fixes branch October 30, 2024 00:30
@akien-mga akien-mga changed the title 2D: Fix various issues and minor performance optimisations 2D: Fix various issues and minor performance optimizations Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment