2D: Fix various issues and minor performance optimizations #98652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes a number of important bug fixes and a performance improvement for managing the texture state and
DrawData
in uniform set 3.Another important change in this PR is to move the
specular_shininess
toPushConstant
state, allowing the field to be used for #97058.Closing #97340 in favour of this, noting that this PR will not address font rendering improvements, which will require separate work. It does improve the performance of text rendering of the test in this comment from 40 fps to 76 fps, due to the minor CPU optimisations included in this PR.
Bugfixes
CanvasItem.draw_primitive()
disregard the texture #97586 for the forward+ renderer, but not compatibility