Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix unreachable code in DisplayServer #103286

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

AThousandShips
Copy link
Member

Regression from:

Unsure why these weren't caught by CI, will see if I can check some settings to try and catch these

@AThousandShips
Copy link
Member Author

Fixing the error on Web right now

@bruvzg
Copy link
Member

bruvzg commented Feb 25, 2025

Unsure why these weren't caught by CI, will see if I can check some settings to try and catch these

What's the config/compiler that's catching these? I'm always building with warnings=extra werror=yes and not getting any errors.

@AThousandShips
Copy link
Member Author

AThousandShips commented Feb 25, 2025

Catching it with MSVC, with dev_build=Yes dev_mode=Yes

@AThousandShips
Copy link
Member Author

Running Windows CI with dev_build=Yes catches the issue in CI, but not just with the default flags, unsure why this is, could be a bug in how things get configured

@akien-mga
Copy link
Member

Running Windows CI with dev_build=Yes catches the issue in CI, but not just with the default flags, unsure why this is, could be a bug in how things get configured

Might be because CI builds with debug_symbols=no. MSVC might be able to catch more warnings when debug symbols are being generated, I don't know.

@Repiteo Repiteo merged commit 6ea7798 into godotengine:master Feb 25, 2025
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Feb 25, 2025

Thanks!

@AThousandShips AThousandShips deleted the fix_windows_display_2 branch February 25, 2025 19:38
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants