-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Windows] Offload RenderingDevice
creation test to subprocess.
#103245
Conversation
I get this build error with mingw-gcc from Fedora 41:
Seems like Fedora's mingw64 |
Replaced it with |
I'm now getting this linking error:
Building with |
This comment was marked as outdated.
This comment was marked as outdated.
Moved it to |
I made a test build with the official buildsystem for Windows x86_64 and x86_32, both standard and mono: https://editor.godotengine.org/testing/4.4-rc1-pr103245/ Edit: New build from ab71749, please test this one: https://editor.godotengine.org/testing/4.4-rc1-pr103245-v2/ I'll ask in the issue for testers. |
This will block users from creating new projects using the Forward+ and Mobile renderers on the affected drivers. We will need to use a different check for project creation because there we only care if RD is supported, we don't care if RD can run at the same time as OpenGL |
Added second RD only check version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have two confirmations that it fixes the crash for affected users on Windows, so let's go!
Some more testing will be needed to validate whether VRAM compression and lightmap baking works, but this will be easier to do once this is included in 4.4.rc2 (and worst case, this can be fixed after the 4.4 release if it doesn't work, as long as it's not crashing).
Thanks! |
return true; | ||
} else { | ||
created_rendering_device = RenderingDeviceCreationStatus::FAILURE; | ||
return false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This causes unreachable code error, will write a fix (Seems we need more fine-grained testing for Windows builds as this is the second regression in a short bit)
Might fix #101659