[Linux/BSD] Offload RenderingDevice creation test to subprocess. #103560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirming that this fixes the project manager crashes on my end. |
akien-mga
added
the
cherrypick:4.4
akien-mga
reviewed
Mar 4, 2025
akien-mga
approved these changes
Mar 4, 2025
There was a problem hiding this comment.
Tested briefly on Fedora 41 with
OpenGL API 4.6 (Core Profile) Mesa 25.0.0 - Compatibility - Using Device: AMD - AMD Radeon Graphics (radeonsi, phoenix, LLVM 19.1.7, DRM 3.61, 6.13.5-200.fc41.x86_64)
I couldn't reproduce the bug but this doesn't seem to cause issues either. I can create Forward+ projects in the project manager.
|
I downloaded Godot 4.4 mono, it doesn't crash on the project manager. However, I haven't tried to open any of my projects. But I assume it works fine. |
|
Thanks! |
|
Cherry-picked for 4.4.1. |
akien-mga
added
topic:porting
and removed
cherrypick:4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #103245, but for Linux.
Fixes #103518
As with Windows, since I can't reproduce the crash, I can't fully test if it's detecting crashing context correctly.