Make EditorProperty and its child EditorProperty behave like sibling nodes when handling mouse events
#103316
Conversation
Rindbee
force-pushed
the
make-EditorProperty-and-its-children-behave-like-sibling-nodes
branch
from
df322b8 to
5b2d73f
Compare
Rindbee
changed the title
EditorProperty and its child EditorProperty behave like sibling nodes
|
Why is this chosen for 4.5? This is a fix for a common issue, not a new feature, #101768 did not solve the issue completely. |
|
What case wasn't solved? |
|
Also we are in the RC phase and we merge only critical fixes currently |
I can still see the inspector shifting abruptly when expanding some properties, such as when editing a material. 0226.mp4 |
|
Tested this PR and while folding now works properly, toggling some properties can still cause jumps: godot.windows.editor.dev.x86_64_FeyJMyZthI.mp4It's caused by inspector refresh though, and the scroll ends up in the same position, so it's fine. |
editor/editor_inspector.cpp
Outdated
| @@ -918,6 +918,9 @@ void EditorProperty::gui_input(const Ref<InputEvent> &p_event) { | |||
|
|
|||
| if (me.is_valid()) { | |||
| Vector2 mpos = me->get_position(); | |||
| if (bottom_child_rect.has_point(mpos)) { | |||
| return; // Makes child EditorProperties behave like sibling nodes. | |||
There was a problem hiding this comment.
Just when handling mouse events.
In this case, when clicking on the Label of a child EditorProperty, we don't want the parent EditorProperty's menu to pop up (RMB), but we want the root inspector to have focus (LMB).
… sibling nodes Let `EditorProperty::gui_input()` no longer handle mouse events that occur in the child EditorProperty rect.
Rindbee
force-pushed
the
make-EditorProperty-and-its-children-behave-like-sibling-nodes
branch
from
5b2d73f to
62aa4a6
Compare
Rindbee
changed the title
EditorProperty and its child EditorProperty behave like sibling nodesEditorProperty and its child EditorProperty behave like sibling nodes when handling mouse events
|
Thanks! |
Rindbee
deleted the
make-EditorProperty-and-its-children-behave-like-sibling-nodes
branch
akien-mga
added
the
cherrypick:4.4
|
Cherry-picked for 4.4.1. |
akien-mga
removed
the
cherrypick:4.4
Let
EditorProperty::gui_input()no longer handle mouse events that occur in the child EditorProperty rect (bottom_child_rect).This is another way to solve issues like #88848 , but avoids #100695 .
Bugsquad edit:
Fix #103578