Replace QuickOpenDialog navigation keys with actions #103476
Open
+23
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoBeWi
force-pushed
the
more_action_for_quick_open._quick_action
branch
from
f94af84 to
7ee808d
Compare
Maran23
reviewed
Mar 3, 2025
| _move_selection_index(key_event->get_keycode()); | ||
| queue_redraw(); | ||
| accept_event(); | ||
| Key move_selection = Key::NONE; |
There was a problem hiding this comment.
move_selection can be a bool here, like before, since there is not really any benefit to save the Key here, unless I miss something?
There was a problem hiding this comment.
_move_selection_index() takes Key argument. It's simpler this way than rewriting its logic.
There was a problem hiding this comment.
Sure, but should we replace key_event->get_keycode() with move_selection then?
There was a problem hiding this comment.
I mean, the Key here is used as navigation enum, not actual key code. _move_selection_index() still somehow needs to decide what movement it should perform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #96400