Use InputMap actions consistently across all LineEdit's that filter an underlying Tree or ItemList. #96400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n underlying Tree or ItemList. - Instead of checking for Key::UP, Key::DOWN, Key::PAGEUP, Key::PAGEDOWN etc., we rather check for the action like 'ui_up' or 'ui_down'. - Also use AcceptDialog's 'register_text_enter' functionality to consistently close a dialog when ENTER is pressed while the LineEdit has focus (instead of redirecting ENTER keys to e.g. the underlying Tree). - Unify the LineEdit filter behavior for the SceneTreeDialog and corresponding usages - Improve OK Button disablement (something should be selected)
KoBeWi
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
VisualShader editor changes might use another check, as they are bigger and I'm not familiar with this area, but otherwise looks good.
Seeing all this duplicated code for handling navigation, I wonder if we should have a custom DialogLineEdit class that does it automatically for assigned Control.
AThousandShips
approved these changes
Sep 13, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96212 (review)
Similiar to #43663
Key::UP,Key::DOWN,Key::PAGEUP,Key::PAGEDOWNetc., we rather check for the action likeui_uporui_downetc..register_text_enterfunctionality to consistently close a dialog whenENTERis pressed while theLineEdithas focus (instead of redirectingENTERkeys to e.g. the underlyingTree).LineEditfilter behavior for theSceneTreeDialogand corresponding usages.While at the
editor/plugins/visual_shader_editor_plugin.cpp, found some related things I fixed while there:varyingdialogs are shownAcceptDialognow, which enables the same navigation as for other dialogs (press ENTER to confirm, ESCAPE to close, was the only dialog where this does not work)Affected dialogs and how to test them (Navigate while the LineEdit has focus, press ENTER to confirm selection):
CreateDialog(Create Node or Resource)EditorCommandPalette(CTRL+Shift+P)EditorHelpSearch(F1)EditorQuickOpen(CTRL+Shift+O)GridMapEditor(GridMap with MeshLibrary)PropertySelector(MultiplayerSynchronizer-> add property)SceneTreeDialog(@export var abc: NodePath-> Assign a Node, used in AnimationTrackEditor, ReplicationEditor)ScriptEditorQuickOpen(editScript-> CTRL+ALT+F)ThemeTypeDialog(editTheme-> add type)VisualShaderEditor, including varying dialog and shader preview dialog (Shader Editor)