Make pressing Enter confirm project creation/import in the project manager #97453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
force-pushed
the
project-manager-enter-accepts-dialog
branch
from
45d887d to
05ce362
Compare
Mickeon
reviewed
Sep 25, 2024
Calinou
force-pushed
the
project-manager-enter-accepts-dialog
branch
from
05ce362 to
262fdb3
Compare
Maran23
reviewed
Sep 25, 2024
Calinou
force-pushed
the
project-manager-enter-accepts-dialog
branch
from
262fdb3 to
1bf8102
Compare
Maran23
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Code looks good and makes sense. A nice improvement for usability.
Also matches pretty much all other dialogs, as I also identified/unified in #96400.
The text_submitted SceneStringName could be used/replaced everywhere else in a future PR.
Calinou
force-pushed
the
project-manager-enter-accepts-dialog
branch
from
1bf8102 to
29574fb
Compare
…nager This makes the project manager more friendly to keyboard usage. You can now create projects more easily without touching the mouse by opening the project manager, pressing Ctrl + N, entering a project name and pressing Enter.
Calinou
force-pushed
the
project-manager-enter-accepts-dialog
branch
from
29574fb to
c15fe90
Compare
radiantgurl
approved these changes
Sep 27, 2024
akien-mga
approved these changes
Sep 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the project manager more friendly to keyboard usage.
You can now create projects more easily without touching the mouse by opening the project manager, pressing Ctrl + N (shortcut for the Create button), entering a project name and pressing Enter.