Introduce OS.set_drag_mode()
#23972
Introduce OS.set_drag_mode()
#23972
Conversation
toger5
force-pushed
the
feature/set-wm-drag-mode
branch
from
e16ec87 to
4ab495f
Compare
toger5
force-pushed
the
feature/set-wm-drag-mode
branch
2 times, most recently
from
c24f0e3 to
29ab488
Compare
|
Could you squash the commits together? Note also that it fails building on OSX: https://travis-ci.org/godotengine/godot/jobs/459525810 |
|
@akien-mga |
|
Th error on osx is just a matter of replacing OS with OS_OSX |
OS.set_drag_mode() tells the window manager how to handle drag events on your app. For example, setting DRAG_MODE_MOVE will tell the window manager to start moving your window on drag. Setting DRAG_MODE_RESIZE_BOTTOMRIGHT will tell the window manger to start resizing your window from the bottom right on drag. Support for these features is critical for borderless apps which need to support normal window manager interactions.
toger5
force-pushed
the
feature/set-wm-drag-mode
branch
from
29ab488 to
7a9b1e6
Compare
|
@akien-mga fixed the OS X issue and rebased |
|
What's the status of this? |
|
confilcts :( ... no time right now. might check it this weekend |
There was a problem hiding this comment.
On Windows resize is a bit laggy (but same is true for normal Godot window resize).
On Linux/X11 resize lags massively, leave dirty traces and sometimes blinks during resize (it's much more noticeable with transparent window, but happens win non transparent too).
| @@ -263,6 +264,10 @@ class OS_OSX : public OS_Unix { | |||
| void set_mouse_mode(MouseMode p_mode); | |||
| MouseMode get_mouse_mode() const; | |||
|
|
|||
| void set_drag_mode(DragMode p_drag_mode); | |||
| OS::DragMode get_drag_mode() const; | |||
| bool process_drag_mode(NSEvent *event); | |||
There was a problem hiding this comment.
OS_OSX::process_drag_mode()is defined but not implemented (probably copy-paste from X11)X11andWindowsplatforms don't set defaultdrag_modevalue (DRAG_MODE_NONE).
| } | ||
|
|
||
| - (void)mouseUp:(NSEvent *)event { | ||
| if (OS_OSX::singleton->drag_mode == OS::DRAG_MODE_MOVE && [event clickCount] == 2) { | ||
| OS_OSX::singleton->set_window_maximized(!OS_OSX::singleton->is_window_maximized()); |
There was a problem hiding this comment.
On macOS double-clicking window title should minimize window not maximize, and there's nothing like this implemented on other platforms.
| case DRAG_MODE_RESIZE_TOPRIGHT: return HTTOPRIGHT; | ||
| case DRAG_MODE_RESIZE_BOTTOMRIGHT: return HTBOTTOMRIGHT; | ||
| case DRAG_MODE_RESIZE_BOTTOMLEFT: return HTBOTTOMLEFT; | ||
| case DRAG_MODE_NONE: return HTCLIENT; |
There was a problem hiding this comment.
DRAG_MODE_NONE / default should return DefWindowProcW(hWnd, uMsg, wParam, lParam); instead, returning HTCLIENT will break resizing of normal (non-borderless) windows.
|
And another problem, it's possible to resize borderless window to zero size and render it unusable. |
akien-mga
changed the title
OS.set_drag_mode() rebaseOS.set_drag_mode()
|
There are quite a few outstanding issues that still need to be addressed. |
|
Not sure if i find time for it currently. Maybe someone else need to take care of it. |
|
@toger5 Is this still desired? If so, this feature would probably need to be redone from scratch, considering the OS and DisplayServer split. If not, abandoned pull requests will be closed in the future as announced here. I see that above you say that you may not have time for this, if you can't fix this up yourself, feel free to close it. |
|
I guess we close this one. It is not that propable that I will work on this commit. I think a lot it did was fixing issues with the old system. So I will close for now. |
same as #16512 but rebased.