Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an editor window color project setting #34528

Closed
wants to merge 1 commit into from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Dec 21, 2019

This can be used to distinguish projects more easily, which is especially helpful when working on multiple projects at the same time.

The current coloring is a proof of concept. It does the job, but it's not that pretty. It'd be ideal if we could change the window border colors, but this requires us to implement client-side decorations first. (In other words, disabling the system-provided window borders and adding our own.)

This feature is inspired by the Visual Studio Code add-on Peacock.

Preview

Editor colors

This can be used to distinguish projects more easily, which is
especially helpful when working on multiple projects at the same time.
@bruvzg
Copy link
Member

bruvzg commented Feb 23, 2020

The current coloring is a proof of concept. It does the job, but it's not that pretty. It'd be ideal if we could change the window border colors, but this requires us to implement client-side decorations first. (In other words, disabling the system-provided window borders and adding our own.)

There is PR for implementing custom window decorations - #23972, but it's not updated for the long time and had some issues last time I have tested it.

@Calinou Calinou added this to the 4.0 milestone Mar 12, 2020
@aaronfranke
Copy link
Member

@Calinou Is this still desired? If so, it needs to be rebased on the latest master branch.

@Calinou
Copy link
Member Author

Calinou commented Aug 2, 2020

@aaronfranke Yes, but it probably needs to be redone to make use of client-side decorations once we implement those. In other words, we have to replace the system-provided window borders with our own.

@aaronfranke
Copy link
Member

Marking as Draft because we should wait to see what happens with client-side window decoration support.

@aaronfranke aaronfranke marked this pull request as draft August 22, 2021 03:10
@akien-mga
Copy link
Member

We discussed this in a PR review meeting and we don't really see much need for it. This should probably be moved to a proposal so the community can properly discuss and propose use cases where they would really use this. Otherwise adding a project settings for this seems niche enough that most users wouldn't ever find it and use it.

@RokeJulianLockhart
Copy link

This should be the job of the WM.

@AThousandShips AThousandShips removed this from the 4.0 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants