Decrease the editor FPS cap when the window is unfocused #29297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
May 30, 2019
This decreases CPU/GPU usage when the window is unfocused, which can be beneficial to laptop users. This also makes the low-processor mode sleep project setting no longer affect the editor. Instead, two new editor settings now define the duration of sleeping when the editor is focused and unfocused. This closes godotengine#24209 and partially addresses godotengine#29257.
Calinou
force-pushed
the
decrease-editor-fps-unfocused
branch
from
84781dc to
ac14efc
Compare
|
Thanks! |
neikeq
reviewed
May 30, 2019
| if (p_what == MainLoop::NOTIFICATION_WM_FOCUS_OUT) { | ||
|
|
||
| // Set a low FPS cap to decrease CPU/GPU usage while the editor is unfocused | ||
| OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/unfocused_low_processor_mode_sleep_usec"))); |
There was a problem hiding this comment.
What if low_processor_usage_mode_sleep_usec was already enabled but the setting is disabled? This line would turn off low_processor_usage_mode_sleep_usec.
There was a problem hiding this comment.
The low_processor_mode_sleep_usec setting is independent from low_processor_mode (the former accepts an integer, the latter accepts a boolean). Note that having low-processor mode enabled with low_processor_mode_sleep_usec set to 0 is not the same as having it disabled. In this case, framerate will be unlimited, but the application will not be re-rendered if nothing changes in the viewport.
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decreases CPU/GPU usage when the window is unfocused, which can be beneficial to laptop users.
This also makes the low-processor mode sleep project setting no longer affect the editor. Instead, two new editor settings now define the duration of sleeping when the editor is focused and unfocused.
There might be a few cases where disabling the unfocused FPS cap makes sense (e.g. someone who's previewing shaders while working in another window), so I thought it'd make sense to have new settings here.
This closes #24209 and partially addresses #29257.