Move Debug menu logic to DebuggerEditorPlugin, allow 4 debug instances

[Faless]

In this PR:

• Move Debug menu logic to DebuggerEditorPlugin (editor run [native] now use settings to read the props).
• Small refactor to "Debug" menu to allow up to 4 instances (closes Allow launching multiple game instances godot-proposals#560 , closes Build and play buttons to run multiple instances at once #7008 )
• Properly remember last selected "run multiple" option .

[akien-mga]

Awesome to get more code out of the huge editor_node.cpp :)

[akien-mga]

Do command line debug options still work as expected after this change?

  --remote-debug <address>         Remote debug (<host/IP>:<port> address).
  --debug-collisions               Show collision shapes when running the scene.
  --debug-navigation               Show navigation polygons when running the scene.

[Faless]

Do command line debug options still work as expected after this change?

Yes, EditorRun still uses them for the command line but, when deciding which one to set, it reads the booleans from EditorSettings project metadata instead of a member var set by the EditorNode.

godot/editor/editor_run.cpp

Lines 60 to 68 in bfc1b76

	bool debug_collisions = EditorSettings::get_singleton()->get_project_metadata("debug_options", "run_debug_collisons", false);
	bool debug_navigation = EditorSettings::get_singleton()->get_project_metadata("debug_options", "run_debug_navigation", false);
	if (debug_collisions) {
	args.push_back("--debug-collisions");
	}
	if (debug_navigation) {
	args.push_back("--debug-navigation");
	}

EDIT: And.. I've tested them :)

[akien-mga]

Thanks!

[realkotob]

Is it possible to cherrypick this into 3.2.x ?

We have an ongoing client project that we regularly test with 4 instances (the final production target is 8 local devices) so having this feature would be god-sent!

[Faless]

Is it possible to cherrypick this into 3.2.x ?

Sadly no, the code in the 3.2 branch is completely different from the one in master branch. namely multiple instance support in the debugger has been added in #36244 and cherry picking that is too risky as it may introduce many regressions.

[kelteseth]

@Faless thanks for this really nice feature! I toyed with the multiple instance feature a bit and I have some questions.

1. Is there a way to set command line arguments for every instance? For example, I want instance 1 to be the server and the other 3 to be clients. My current workflow in GD 3 is to start the server in the Editor and a client via a .bat file.

2. Is there a way to see the remote tree for a specific instance?

Cheers!

[Calinou]

Is there a way to set command line arguments for every instance? For example, I want instance 1 to be the server and the other 3 to be clients. My current workflow in GD 3 is to start the server in the Editor and a client via a .bat file.

Right now, there's no widget in the editor to do this. You can set the command-line arguments using Main Run Args in the Project Settings, but this affects all instances. See godotengine/godot-proposals#522.