Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how the 3D editor viewport's resolution scale is changed #45269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jan 18, 2021

  • Removed the Half Resolution per-viewport setting in favor of an editor setting that applies to all 3D viewports in all projects.
  • Use an automatic rendering scale by default that's set to 100% on loDPI displays and 50% on hiDPI displays (editor scale >= 1.667).
  • Add 25% and 33% scaling options in the Editor Settings. This is useful for low-end hardware with hiDPI displays (such as 4K laptops).

The rendering scale is updated when the editor setting changes, so no restart is required to apply rendering scale changes (as before).

This pull request can be remade for the 3.x branch if we agree on this one.

This closes godotengine/godot-proposals#2125.

@alexfreyre
Copy link

alexfreyre commented Feb 14, 2021

I agree with this PR but it looks that the main concern is about hiDPI displays,
I have a laptops that has 3000x2000 resolution and an Nvidia 940m. I use to connect an external FullHD monitor, and always I am facing that 1920x1080 is too much for my laptop with the viewport at 100% but 50% looks very bad.

Therefore I would like to have the 75% option, in my case there is no use case either 33% nor 25% because I set a low resolution in my system.

On the other hand I like a lot how Unreal has a 0-100% parameter that you can tweak according to your need.

Why we don't expose to the viewport the project-settings option "Shrink":
Under display/window/stretch/shrink

Or maybe a 0-100% viewport resolution scale

@Calinou
Copy link
Member Author

Calinou commented Feb 14, 2021

Therefore I would like to have the 75% option, in my case there is no use case either 33% nor 25% because I set a low resolution in my system.

A 75% option requires linear filtering to look correct, and this option isn't available yet in Godot (it might be hackable by getting the ViewportTexture and enabling Texture::FLAG_FILTER on it). This can be implemented in a separate PR.

- Removed the Half Resolution per-viewport setting in favor of an
  editor setting that applies to all 3D viewports in all projects.
- Use an automatic rendering scale by default that's set to 100% on
  loDPI displays and 50% on hiDPI displays (editor scale >= 1.667).
- Add 25% and 33% scaling options in the Editor Settings.
  This is useful for low-end hardware with hiDPI displays
  (such as 4K laptops).

The rendering scale is updated when the editor setting changes,
so no restart is required to apply rendering scale changes (as before).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make an option to use third-resolution or, even quarter resolution in the viewport . .
4 participants