-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow any number of frames for the SDFGI Frames To Converge setting #50796
Allow any number of frames for the SDFGI Frames To Converge setting #50796
Conversation
cfca757
to
fbf6d91
Compare
From my testing, it seems to work well enough if the camera doesn't move too fast. The usability of higher values also depends on your cascades' individual size (which is determined by the Cell Size property). With larger cell sizes, GI will be less detailed but a given cascade will cover a larger area, which reduces the need for SDFGI generation when the camera is moving. |
fbf6d91
to
5bd0f0b
Compare
5bd0f0b
to
edbbdc3
Compare
edbbdc3
to
a2945a1
Compare
Rebased and tested again, it works as expected. Note that I decreased the maximum value from 300 to 120, as values above 120 don't bring much of a benefit compared to the performance drop caused by fast camera movement. As an added sidenote, #56761 makes very low frame convergence numbers viable if you combine it with a high SDFGI Probe Ray Count setting. You can get fully real-time GI in a way similar to VoxelGI, but with SDFGI 🙂 |
9dfa7c6
to
1c1a903
Compare
1c1a903
to
32c98c4
Compare
This allows for more flexibility over the stability versus update speed compromise.
32c98c4
to
25c4a10
Compare
I will entirely change this code when I get a bit more time, so feel free to close this one. |
This allows for more flexibility over the stability versus update speed compromise.
This closes #50773.
Preview
Edit: This pull request was amended to limit the maximum value to 120 (instead of 300). Higher values don't bring a significant benefit, but make performance drops more extreme when the camera moves fast.
Bounce Feedback 0, Energy 1
Bounce Feedback 0.5, Energy 0.5