Allow any number of frames for the SDFGI Probe Ray Count setting #58696
+19
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for more flexibility over the performance versus quality compromise. The value can now be set as low as 1 for very fast (but low-quality) GI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #50796 (can be merged independently).
This allows for more flexibility over the performance versus quality compromise. The value can now be set as low as 1 for very fast (but low-quality) GI.
Testing project: test_sdfgi_probe_ray_count.zip
Preview
Default setting
Same as before.
New lowest setting
More blotchy results, but significantly faster. The GI keeps the same effective range or probe density.
In mostly static scenes, quality could be improved without impacting performance by increasing the number of frames to converge above 30. This can be done if #50796 is merged.