Rework AnimatedTexture's fps into base_delay
#65182
Closed
+21
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mickeon
force-pushed
the
animated-texture-base-delay
branch
from
91fa85f to
27b6e53
Compare
Mickeon
force-pushed
the
animated-texture-base-delay
branch
from
27b6e53 to
d5583f8
Compare
`fps` has been turned into `base_delay`. `frame_n/delay_sec` renamed to `frame_n/delay` (prefixes exist, making the name redundant).
Mickeon
force-pushed
the
animated-texture-base-delay
branch
from
d5583f8 to
ad1b031
Compare
|
Closing, as #65188 has been considered greatly superior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #65188.
As lightly mentioned in #64657 while updating the description, the
fpsproperty in AnimatedTexture has somewhat confusing behaviour. Mainly, it is expressed in frames per seconds, yet each individual frame's delay is expressed in seconds, making it a confusing soup to work with, and explain in the documentation, despite being such a simple concept.This PR attempts to address that.
fpshas been turned intobase_delay.frame_n/delay_sechas been renamed toframe_n/delay(prefixes exist, making the previous name redundant).This is more so an experiment, a test, for the other PR. See #65188.