Don't generate CSGPolygon3D shape before the assigned path is inside tree #72427
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71240
Within the
NOTIFICATION_ENTER_TREE
, we don't know at this point if the assignedpath
node has actually entered the tree. So I removed the_update_collision_faces()
call here, and replaced it by a_make_dirty()
call, like it's done in theset_use_collision
method, so the update is deferred.Also I added a small check inside the
_build_brush()
to return an empty brush if thepath
node is not inside tree.