Added support for 'print' command in local (command line -d) debugger #73729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 22, 2023
wenqiangwang
force-pushed
the
local_debuggger_expr_evalulation
branch
from
617e851 to
a174337
Compare
wenqiangwang
force-pushed
the
local_debuggger_expr_evalulation
branch
from
a174337 to
43c70c7
Compare
|
Can anyone please review? |
|
Why close? |
|
It has been there for a long time. It require extra reviews but no one did.
So I closed it. If this something that you can help, I can fix the merge
conflict and check it in.
…On Wed, Sep 18, 2024, 12:10 AM Zireael07 ***@***.***> wrote:
Why close?
—
Reply to this email directly, view it on GitHub
<#73729 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXZSA7S6GVT2LPNSWUBOFDZXERNZAVCNFSM6AAAAABOMUVXVWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJXGY3TMOJXGY>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
I think it seems interesting, so it could be good to reopen. I apologize it hasn't been fully reviewed/approved yet, there's a lot of PR backlog and not a lot of contributors are familiar with the command line debugger and GDScript to sign off on this implementation. But from a quick glance it looks simple, I would try it out when I find some time to confirm both the bug and the fix. |
|
That will be great! Unfortunately my branch was related and this cannot be re-opened. Instead I created a new PR: Please review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixed #73389