-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for print
command in local (command line -d
) debugger
#97218
Add support for print
command in local (command line -d
) debugger
#97218
Conversation
wenqiangwang
commented
Sep 20, 2024
•
edited by AThousandShips
Loading
edited by AThousandShips
- Bugsquad edit, fixes: 'print' command in command line debugger does not show anything #73389
This is an attempt to reopen PR #73729 after the branch deleted |
print
command in local (command line -d
) debugger
Thank for the feedback, everyone. The comments are now resolved. |
Can you please approve or give feedback? |
@akien-mga, at the moment, do you think there is anything I can do to get this change in? Thanks. |
You can squash the commits to make the PR ready to merge. But it still requires an approval for a maintainer, which needs some time. I plan to test it myself to confirm the fix, but I'm quite busy, so I can't say when I will do it. |
acde6be
to
9a94353
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. There are differences between GDScript and Expression
, so it would be ideal to implement this separately (parsing and compiling individual GDScript expressions). But since we don't have a foundation for this, it might make sense to use Expression
for now. Especially since the recently merged REPL (#97647) also uses Expression
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sorry for the delay, I was on leave in October.
Thanks for looking, everyone! |
Thanks! Congratulations on your first contribution! 🎉 |
And thanks for your patience with our slow review process :) |