Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print extended hardware information when running in verbose mode #75025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Mar 17, 2023

This is useful for troubleshooting, especially for player-submitted reports in exported projects. This complements godotengine/godot-proposals#4732, but a dedicated dialog should still be added to the editor as not every user can easily run Godot from a terminal (e.g. Android/HTML5).

This is the generated output on my system when running with --verbose:

Device model: GenericDevice
CPU model: 13th Gen Intel(R) Core(TM) i9-13900K (32 threads)
Audio mix rate: 44100 Hz
Output audio devices:
  #0: Default (selected)
  #1: alsa_output.pci-0000_01_00.1.hdmi-stereo
  #2: alsa_output.usb-C-Media_Electronics_Inc._USB_Advanced_Audio_Device-00.analog-stereo
  #3: alsa_output.usb-Generic_USB_Audio-00.analog-stereo
Input audio devices:
  #0: Default
  #1: alsa_input.usb-C-Media_Electronics_Inc._USB_Advanced_Audio_Device-00.analog-stereo
  #2: alsa_input.usb-Generic_USB_Audio-00.iec958-stereo
Displays:
  #0: (0, 0), 3840x2160, 119.88 Hz, 60 dpi, scale factor: 1.00 (maximum: 1.00), usable rect: (0, 0), 3840x2160

@MJacred
Copy link
Contributor

MJacred commented Dec 14, 2024

@Calinou: I believe we can add info on connected midi inputs (I have not experience with these. It feels weird to have to open/close the MIDI driver manually. And it's not exposed in the API to check if the driver already has been initialized) and joypads (names; note if no button mapping).
It should be noted that the way the Joypad name is retrieved could change, if it's ok for me to change the output for xinput device names (which would make the (end user's) code logic consistent across platforms).
And the graphics card info could also be added.

@Calinou
Copy link
Member Author

Calinou commented Dec 18, 2024

@MJacred I've added MIDI inputs and GPU driver version to this PR. (The GPU model name is already stated in the header printed on every startup even in non-verbose mode, so I didn't repeat it.)

There's the question of whether we should move the GPU driver version to the non-verbose header, but it impacts startup times when queried the first time (especially on Linux), so I'd prefer not until we find a way to address this slowdown.

@Calinou Calinou force-pushed the verbose-print-hardware-information branch from 2784e7c to f1a5d37 Compare December 18, 2024 17:19
This is useful for troubleshooting, especially for player-submitted
reports in exported projects.
@Calinou Calinou force-pushed the verbose-print-hardware-information branch from f1a5d37 to 0eec726 Compare December 18, 2024 17:20
@MJacred
Copy link
Contributor

MJacred commented Dec 18, 2024

There's the question of whether we should move the GPU driver version to the non-verbose header, but it impacts startup times when queried the first time (especially on Linux), so I'd prefer not until we find a way to address this slowdown.

Sounds reasonable to leave it out (unless the slowdown can be addressed).
Personally, I don't think we need to worry about this. Eventually, we'll get do that editor menu, where all the important software and hardware info is listed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants