Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement get_model_name on macOS and Windows. #99112

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Implement get_model_name on macOS and Windows. #99112

merged 1 commit into from
Nov 12, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Nov 12, 2024

I have noticed that it's used in #75025, but not implemented on any desktop OS.

  • On macOS, it is a MacX,Y model identifier (similar to existing iOS code).
  • On Windows, it's either manufacturer specific model ID (on laptops with OEM Windows install) or motherboard name (on custom desktop builds), probably less useful, but still better than GenericDevice.

@bruvzg bruvzg added this to the 4.x milestone Nov 12, 2024
@bruvzg bruvzg requested review from a team as code owners November 12, 2024 10:24
@akien-mga akien-mga modified the milestones: 4.x, 4.4 Nov 12, 2024
@Repiteo Repiteo merged commit cb286da into godotengine:master Nov 12, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 12, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement platform:macos platform:windows topic:porting
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@bruvzg @Repiteo @akien-mga