Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show names of files in the remove files confirmation dialog #85290

Closed

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian commented Nov 24, 2023

Resolves #85261

Note the whole message is a TTR and I think it's better not break it, so have to add the filenames below that messgae.

It looks like this now:

image

I do feel it's can be improved in UX perspective, maybe I should use RichTextlabel and at least make theses filenames bold.

@timothyqiu
Copy link
Member

The "Files to be deleted" part is not translated. You can append this to the message, e.g.:

vformat(TTR("Remove the selected files from the project? (Cannot be undone.)\nDepending on your filesystem configuration, the files will either be moved to the system trash or deleted permanently.\nFiles to be deleted: %s"), files_string)

@YuriSizov YuriSizov changed the title Support show filename in "File remove" confirmation Show names of files in the remove files confirmation dialog Nov 24, 2023
@YuriSizov
Copy link
Contributor

You should probably use an item list or a tree here. See similar dialogs which list files. You will have to create a custom layout for the dialog and can't use set_text anymore, but the way it looks right now is not great.

Also the commit message can probably be cleaned up a bit :)

@jsjtxietian jsjtxietian marked this pull request as draft November 24, 2023 15:30
@jsjtxietian jsjtxietian marked this pull request as draft November 24, 2023 15:30
@jsjtxietian jsjtxietian force-pushed the show-file-name-when-delete branch from a126919 to 35793fd Compare November 29, 2023 07:43
@jsjtxietian
Copy link
Contributor Author

Looks better now ,but still have to deal with the alignment:

image

@AThousandShips AThousandShips modified the milestones: 4.3, 4.4 Jul 7, 2024
@pafuent
Copy link
Contributor

pafuent commented Oct 24, 2024

@jsjtxietian If you don't have time to work on this anymore, I can try to rebase this PR
If you agree, I'll create a new PR because I can't update yours. Of course I'll add you as a co author.

@jsjtxietian
Copy link
Contributor Author

jsjtxietian commented Oct 24, 2024

If you agree, I'll create a new PR because I can't update yours. Of course I'll add you as a co author.

Please Do! I've been quite busy recently and probably will be busy till the end of this year, so I won't be able to update this pr recently, fell free to take it.

@akien-mga
Copy link
Member

Superseded by #98539.

@akien-mga akien-mga closed this Nov 13, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Nov 13, 2024
@jsjtxietian jsjtxietian deleted the show-file-name-when-delete branch November 13, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"File remove" confirmation has no file name.
6 participants