-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show names of files in the remove files confirmation dialog #85290
Show names of files in the remove files confirmation dialog #85290
Conversation
The "Files to be deleted" part is not translated. You can append this to the message, e.g.:
|
You should probably use an item list or a tree here. See similar dialogs which list files. You will have to create a custom layout for the dialog and can't use Also the commit message can probably be cleaned up a bit :) |
a126919
to
35793fd
Compare
@jsjtxietian If you don't have time to work on this anymore, I can try to rebase this PR |
Please Do! I've been quite busy recently and probably will be busy till the end of this year, so I won't be able to update this pr recently, fell free to take it. |
Superseded by #98539. |
Resolves #85261
Note the whole message is a TTR and I think it's better not break it, so have to add the filenames below that messgae.
It looks like this now:
I do feel it's can be improved in UX perspective, maybe I should use RichTextlabel and at least make theses filenames bold.