-
-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show file names in remove files confirmation dialog #98539
Conversation
1863712
to
200541b
Compare
Can I get a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@KoBeWi I tried a lot of different things trying to know the size of one tree item to set the minimum size of the tree. My plan was to have the size of 5 items as max (for less items just set it to see all the items) if (tree_item_count > 0) {
const uint32_t multiplier = MIN(tree_item_count, 5);
owners->set_custom_minimum_size(Size2(0, 35 * multiplier) * EDSCALE);
} Is there a better way to know the exact size of a tree item? |
There is |
200541b
to
ae1cdef
Compare
After trying several methods to set a custom minimum size, I decided to just use one with a fixed value to keep the code simpler. |
Closes godotengine#85261 Co-authored-by: jsjtxietian <jsjtxietian@outlook.com>
ae1cdef
to
56d01fb
Compare
Thanks! |
Closes #85261
Supersedes #85290
Thanks to @jsjtxietian that implemented most of the code. I just rebased the original PR and did some tweaks to adjust
ItemList
andTree
sizes.