Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting first character with mouse in script editor #88813

Conversation

emre0altan
Copy link
Contributor

@emre0altan emre0altan commented Feb 25, 2024

When a line is wrapped in a text editor, column position for the left most click should point to the end of the last character in the previous line to fix this issue #88632.

@emre0altan emre0altan requested a review from a team as a code owner February 25, 2024 13:18
@AThousandShips AThousandShips changed the title Fixes #88632 by checking if line is wrapped before choosing the closest character Fix selecting first character with mouse in script editor Feb 25, 2024
@AThousandShips AThousandShips added this to the 4.3 milestone Feb 25, 2024
@kitbdev
Copy link
Contributor

kitbdev commented May 10, 2024

This just force-enables mid grapheme caret.
I don't think that this is the correct solution.

Try using characters like ❤️‍🔥, you should not be able to click in the middle of them without caret_mid_grapheme_enabled.

@akien-mga
Copy link
Member

Superseded by #95301. Thanks for the contribution!

@akien-mga akien-mga closed this Aug 16, 2024
@akien-mga akien-mga removed this from the 4.4 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't select first character with mouse in script editor
5 participants